Add PEP slash command - #3544
Conversation
ChrisLovering
left a comment
ChrisLovering
left a comment
There was a problem hiding this comment.
nice change, a few comments, also I'd suggest installing the pre-commit hooks so that your changes get linted when you commit uv run pre-commit install
|
Thanks for approving! Someone should probably test this to see if it works tho |
jb3
left a comment
jb3
left a comment
There was a problem hiding this comment.
This works fine from local testing, just one comment and the below
One thing that would be nice to change: if a user is filling out the autocomplete and enters a number (e.g. 522) it'd be nice to shortcut and put that PEP to the top of the suggestion list, right now it tries to fuzzy find on it which means the results don't appear in the list at all.
Ideally, we either add the result to the top of the list when a match is entered here, or we return only that PEP (only fuzzy finding when there are letters or spaces in the text).
Co-authored-by: Joe Banks <joe@jb3.dev>
|
Done! I've chose to implement this:
|
3 participants
Notes:
10as I think25would be too many and clutter the screenget_pep_embedneeds a better name...Issue: #3543